Add push option to export CLI #231

seonglae · 2025-06-06T14:50:30Z

Summary

add --push flag to export command
allow NotionExporter to push exported content to texonom-raw and texonom-md

Testing

pnpm test (fails: vitest not found)
pnpm lint (fails: eslint command issue)

https://chatgpt.com/codex/tasks/task_e_6842d06cc8908327aba1258d471728c9

codesandbox · 2025-06-06T14:50:33Z

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

cursor

Bug: Unconsented Data Push and Error Suppression

The pushRepos method hardcodes remote repository URLs, pushing user data to specific external repositories without consent. It uses git push --force, risking remote history overwrite and data loss. Furthermore, all git command errors are silently ignored, hiding failures. This includes git remote add origin failing on subsequent runs if the remote exists, potentially causing git push to fail or push to an unintended remote.

packages/cli/src/notion/index.ts#L733-L743

notion-node/packages/cli/src/notion/index.ts

Lines 733 to 743 in 4c84671

    
           run('git branch -M main', this.folder) 
        
           run('git remote add origin https://github.com/texonom/texonom-raw.git', this.folder) 
        
           run('git push -u origin main --force', this.folder) 
        
           // push md 
        
           run('git init', this.md) 
        
           run('git add .', this.md) 
        
           run(`git commit -m "${message}"`, this.md) 
        
           run('git branch -M main', this.md) 
        
           run('git remote add origin https://github.com/texonom/texonom-md.git', this.md) 
        
           run('git push -u origin main --force', this.md)

Fix in Cursor

Bug: Git Command Failures Silently Ignored

The run helper function within pushRepos() silently ignores all git command failures via an empty catch block. This prevents users from being notified of critical issues (e.g., authentication, network, or repository access problems), leading to a false sense of success, hindering debugging, and potentially leaving repositories in inconsistent states.

packages/cli/src/notion/index.ts#L720-L744

notion-node/packages/cli/src/notion/index.ts

Lines 720 to 744 in 4c84671

    
           pushRepos() { 
        
             const run = (cmd: string, cwd: string) => { 
        
               try { 
        
                 execSync(cmd, { cwd, stdio: 'ignore' }) 
        
               } catch {} 
        
             } 
        
             const message = new Date().toString() 
        
             // push raw 
        
             run('git init', this.folder) 
        
             run('git add .', this.folder) 
        
             run(`git commit -m "${message}"`, this.folder) 
        
             run('git branch -M main', this.folder) 
        
             run('git remote add origin https://github.com/texonom/texonom-raw.git', this.folder) 
        
             run('git push -u origin main --force', this.folder) 
        
             // push md 
        
             run('git init', this.md) 
        
             run('git add .', this.md) 
        
             run(`git commit -m "${message}"`, this.md) 
        
             run('git branch -M main', this.md) 
        
             run('git remote add origin https://github.com/texonom/texonom-md.git', this.md) 
        
             run('git push -u origin main --force', this.md) 
        
           }

Fix in Cursor

BugBot free trial expires on June 13, 2025
You have used $0.00 of your $0.00 spend limit so far. Manage your spend limit in the Cursor dashboard.

Was this report helpful? Give feedback by reacting with 👍 or 👎

Copilot

Pull Request Overview

This PR adds a --push flag to the export CLI, enabling automatic Git pushes of exported Notion data to two remote repositories.

Introduces a push property and command‐line flag
Implements a pushRepos() method that initializes Git repos and force‐pushes to designated remotes
Hooks the new flag into the export command to run pushRepos() when requested

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
packages/cli/src/notion/index.ts	Imported `execSync`, added `push` flag/property, implemented git push logic in `pushRepos()`
packages/cli/src/notion/export.ts	Added `--push` option to CLI and wired it to invoke `pushRepos()`

Comments suppressed due to low confidence (1)

packages/cli/src/notion/index.ts:721

The new pushRepos() logic isn’t covered by tests—consider adding unit or integration tests to verify the git commands execute as expected.

  pushRepos() {

Copilot · 2025-06-07T18:00:29Z

packages/cli/src/notion/index.ts

+    const run = (cmd: string, cwd: string) => {
+      try {
+        execSync(cmd, { cwd, stdio: 'ignore' })
+      } catch {}


Silently swallowing errors makes debugging push failures difficult; consider logging caught exceptions or at least printing a warning.

Suggested change

} catch {}

} catch (error) {

console.error(`Failed to execute command "${cmd}" in directory "${cwd}":`, error.message);

}

packages/cli/src/notion/index.ts

feat(cli): add push option for export

3aa9b19

seonglae added the codex label Jun 6, 2025 — with ChatGPT Connector

Fix push option naming

4c84671

cursor bot reviewed Jun 7, 2025

View reviewed changes

seonglae requested a review from Copilot June 7, 2025 17:59

Copilot AI reviewed Jun 7, 2025

View reviewed changes

seonglae self-assigned this Jun 8, 2025

Merge branch 'main' into codex/add---push-flag-for-auto-push-on-commit

da5a807

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add push option to export CLI #231

Add push option to export CLI #231

Uh oh!

seonglae commented Jun 6, 2025

Uh oh!

codesandbox bot commented Jun 6, 2025

Uh oh!

cursor bot left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jun 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

	run('git branch -M main', this.folder)
	run('git remote add origin https://github.com/texonom/texonom-raw.git', this.folder)
	run('git push -u origin main --force', this.folder)

	// push md
	run('git init', this.md)
	run('git add .', this.md)
	run(`git commit -m "${message}"`, this.md)
	run('git branch -M main', this.md)
	run('git remote add origin https://github.com/texonom/texonom-md.git', this.md)
	run('git push -u origin main --force', this.md)


	pushRepos() {
	const run = (cmd: string, cwd: string) => {
	try {
	execSync(cmd, { cwd, stdio: 'ignore' })
	} catch {}
	}
	const message = new Date().toString()

	// push raw
	run('git init', this.folder)
	run('git add .', this.folder)
	run(`git commit -m "${message}"`, this.folder)
	run('git branch -M main', this.folder)
	run('git remote add origin https://github.com/texonom/texonom-raw.git', this.folder)
	run('git push -u origin main --force', this.folder)

	// push md
	run('git init', this.md)
	run('git add .', this.md)
	run(`git commit -m "${message}"`, this.md)
	run('git branch -M main', this.md)
	run('git remote add origin https://github.com/texonom/texonom-md.git', this.md)
	run('git push -u origin main --force', this.md)
	}

-      } catch {}
+      } catch (error) {
+        console.error(`Failed to execute command "${cmd}" in directory "${cwd}":`, error.message);
+      }

Uh oh!

Add push option to export CLI #231

Are you sure you want to change the base?

Add push option to export CLI #231

Uh oh!

Conversation

seonglae commented Jun 6, 2025

Summary

Testing

Uh oh!

codesandbox bot commented Jun 6, 2025

Review or Edit in CodeSandbox

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Unconsented Data Push and Error Suppression

Bug: Git Command Failures Silently Ignored

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jun 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!